style(imgui): use orelse instead of if () ||

src/imgui.zig

@@ -21,8 +21,8 @@ const gba_height = @import("core/ppu.zig").height;
 
 const log = std.log.scoped(.Imgui);
 
-// TODO: Document how I decided on this value (I forgot 😅)
+// two seconds worth of fps values into the past
-const histogram_len = 0x400;
+const histogram_len = 0x80;
 
 /// Immediate-Mode GUI State
 pub const State = struct {
@@ -37,10 +37,7 @@ pub const State = struct {
         var title: [12:0]u8 = [_:0]u8{0} ** 12;
         std.mem.copy(u8, &title, "[No Title]");
 
-        return .{
+        return .{ .title = title, .fps_hist = RingBuffer(u32).init(history) };
-            .title = title,
-            .fps_hist = RingBuffer(u32).init(history),
-        };
     }
 
     pub fn deinit(self: *@This(), allocator: Allocator) void {
@@ -67,17 +64,19 @@ pub fn draw(state: *State, tex_id: GLuint, cpu: *Arm7tdmi) void {
                     break :blk;
                 };
 
-                if (maybe_path) |file_path| {
+                const file_path = maybe_path orelse {
-                    defer nfd.freePath(file_path);
+                    log.warn("did not receive a file path", .{});
-                    log.info("user chose: \"{s}\"", .{file_path});
+                    break :blk;
+                };
+                defer nfd.freePath(file_path);
 
-                    emu.replaceGamepak(cpu, file_path) catch |e| {
+                log.info("user chose: \"{s}\"", .{file_path});
-                        log.err("failed to replace GamePak: {}", .{e});
+                emu.replaceGamepak(cpu, file_path) catch |e| {
-                        break :blk;
+                    log.err("failed to replace GamePak: {}", .{e});
-                    };
+                    break :blk;
+                };
 
-                    state.title = cpu.bus.pak.title ++ [_:0]u8{};
+                state.title = cpu.bus.pak.title ++ [_:0]u8{};
-                }
             }
         }
 
@@ -130,7 +129,7 @@ pub fn draw(state: *State, tex_id: GLuint, cpu: *Arm7tdmi) void {
         defer zgui.end();
 
         const tmp = blk: {
-            var buf: [0x400]u32 = undefined;
+            var buf: [histogram_len]u32 = undefined;
             const len = state.fps_hist.copy(&buf);
 
             break :blk .{ buf, len };