paoda/gb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

chore: clean up TODO messages
All checks were successful
continuous-integration/drone/push Build is passing
Details

Browse Source
This commit is contained in:
Rekai Nyangadzayi Musuka
2021-08-15 23:31:27 -05:00
parent 6215eccb2f
commit aa22e93049
5 changed files with 16 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/apu.rs
View File

@@ -164,8 +164,7 @@ impl Apu {
if self.ctrl.enabled {
// Frame Sequencer reset to Step 0
// TODO: With the current implementation of the frame sequencer,
// what does this even mean?
// TODO: With the current implementation of the frame sequencer, what does this even mean?
// Square Duty units are reset to first step
self.ch1.duty_pos = 0;
@@ -181,8 +180,6 @@ impl Apu {
}
fn reset(&mut self) {
// TODO: Clear readable sound registers
self.ch1.sweep = Default::default();
self.ch1.duty = Default::default();
self.ch1.envelope = Default::default();
@@ -426,7 +423,6 @@ impl Channel1 {
}
if self.freq_timer == 0 {
// TODO: Why is this 2048?
self.freq_timer = (2048 - self.frequency()) * 4;
self.duty_pos = (self.duty_pos + 1) % 8;
}
@@ -572,7 +568,6 @@ impl Channel2 {
}
if self.freq_timer == 0 {
// TODO: Why is this 2048?
self.freq_timer = (2048 - self.frequency()) * 4;
self.duty_pos = (self.duty_pos + 1) % 8;
}