paoda
/
chip8
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Slightly improve code quality

This commit is contained in:
Rekai Musuka 2020-07-13 23:04:58 -05:00
parent 28be6356f2
commit 6b116d2592
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/main.rs
View File

@ -74,9 +74,9 @@ fn init_window(event_loop: &EventLoop<()>) -> Window {
fn draw(chip8_gfx: &[u8], frame: &mut [u8]) { fn draw(chip8_gfx: &[u8], frame: &mut [u8]) {
for (i, pixel) in frame.chunks_exact_mut(4).enumerate() { for (i, pixel) in frame.chunks_exact_mut(4).enumerate() {
let rgba = if chip8_gfx[i] == 1 { let rgba = if chip8_gfx[i] == 1 {
[0xFF, 0xFF, 0xFF, 0xFF] [0xFF; 4]
} else { } else {
[0x00, 0x00, 0x00, 0xFF] [0x00; 4]
}; };
pixel.copy_from_slice(&rgba); pixel.copy_from_slice(&rgba);

5
src/periph.rs
View File

@ -17,7 +17,7 @@ impl Display {
let mut set_vf = false; let mut set_vf = false;
// Each byte in data is a row, with the column being data.len() tall // Each byte in data is a row, with the column being data.len() tall
// This means when writing this sprite, x should not change, but y // This means when writing this sprite, x will change for each bit in a byte and y
// should be incremented by 1 for every new byte we draw to the graphics buffer // should be incremented by 1 for every new byte we draw to the graphics buffer
for (y_offset, byte) in data.iter().enumerate() { for (y_offset, byte) in data.iter().enumerate() {
// Access every bit of the byte // Access every bit of the byte
@ -35,14 +35,13 @@ impl Display {
break; // Stop Drawing this spite and move on to the next break; // Stop Drawing this spite and move on to the next
} }
if bit == 0x1 && self.buf[gfx_i] == 0x1 { if bit == 0x1 && self.buf[gfx_i] == 0x01 {
set_vf = true; set_vf = true;
} }
self.buf[gfx_i] ^= bit; self.buf[gfx_i] ^= bit;
} }
} }
set_vf set_vf
} }
} }