From 6b116d25926957489d76f3210f9824dbab5eb41e Mon Sep 17 00:00:00 2001 From: Rekai Musuka Date: Mon, 13 Jul 2020 23:04:58 -0500 Subject: [PATCH] Slightly improve code quality --- src/main.rs | 4 ++-- src/periph.rs | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/main.rs b/src/main.rs index 9acffec..366ed3a 100644 --- a/src/main.rs +++ b/src/main.rs @@ -74,9 +74,9 @@ fn init_window(event_loop: &EventLoop<()>) -> Window { fn draw(chip8_gfx: &[u8], frame: &mut [u8]) { for (i, pixel) in frame.chunks_exact_mut(4).enumerate() { let rgba = if chip8_gfx[i] == 1 { - [0xFF, 0xFF, 0xFF, 0xFF] + [0xFF; 4] } else { - [0x00, 0x00, 0x00, 0xFF] + [0x00; 4] }; pixel.copy_from_slice(&rgba); diff --git a/src/periph.rs b/src/periph.rs index 03e2d8f..f41bb8a 100644 --- a/src/periph.rs +++ b/src/periph.rs @@ -17,7 +17,7 @@ impl Display { let mut set_vf = false; // Each byte in data is a row, with the column being data.len() tall - // This means when writing this sprite, x should not change, but y + // This means when writing this sprite, x will change for each bit in a byte and y // should be incremented by 1 for every new byte we draw to the graphics buffer for (y_offset, byte) in data.iter().enumerate() { // Access every bit of the byte @@ -35,14 +35,13 @@ impl Display { break; // Stop Drawing this spite and move on to the next } - if bit == 0x1 && self.buf[gfx_i] == 0x1 { + if bit == 0x1 && self.buf[gfx_i] == 0x01 { set_vf = true; } self.buf[gfx_i] ^= bit; } } - set_vf } }