Merge pull request #26 from beatriceo/modal-fix

fixed issue where modal trigger broke navbar

app/assets/javascripts/signaling-server.js

@@ -16,10 +16,12 @@ let pcPeers = {}; // peer connection
 let localstream;
 
 window.onload = () => {
-  currentUser = document.getElementById("current-user").innerHTML;
+  if (document.getElementById("current-user")) {
-  console.log(currentUser)
+    currentUser = document.getElementById("current-user").innerHTML;
-  localVideo = document.getElementById("local-video");
+    console.log(currentUser)
-  remoteVideoContainer = document.getElementById("remote-video-container");
+    localVideo = document.getElementById("local-video");
+    remoteVideoContainer = document.getElementById("remote-video-container");
+  }
 };
 
 // Ice Credentials
@@ -35,8 +37,10 @@ document.onreadystatechange = async () => {
       })
 
       localstream = stream;
-      localVideo.srcObject = stream
+      if (localVideo) {
-      localVideo.muted = true
+        localVideo.srcObject = stream
+        localVideo.muted = true
+      }
     } catch (e) { console.error(e); }
   }
 };
@@ -67,7 +71,11 @@ document.onreadystatechange = async () => {
 //     }
 //   });
 // };
-const chatroomId = document.getElementById('chatroom-hook').dataset["chatroomId"]
+
+if (document.getElementById('chatroom-hook')) {
+  const chatroomId = document.getElementById('chatroom-hook').dataset["chatroomId"]
+
+}
 
 const handleJoinSession = async () => {
   App['chatroom' + chatroomId] = await App.cable.subscriptions.create({

app/javascript/components/modal.js

@@ -0,0 +1,11 @@
+
+const triggerModalEvent = () => {
+  const btn = document.getElementById("modalTrigger");
+  const modal = document.getElementById("myModal");
+
+  btn.addEventListener('click', function(event) {
+    $('#myModal').modal('show');
+  });
+}
+
+export { triggerModalEvent }

app/javascript/packs/application.js

@@ -1,4 +1,9 @@
 import "bootstrap";
 
-import { profilePageAnimation } from '../users/lesson';
+import { triggerModalEvent } from "../components/modal.js";
-profilePageAnimation();
+
+triggerModalEvent();
+
+// import { profilePageAnimation } from '../users/lesson';
+
+// profilePageAnimation();

app/javascript/packs/modal.js

@@ -1,8 +0,0 @@
-import "bootstrap";
-
-const btn = document.getElementById("modalTrigger");
-const modal = document.getElementById("myModal");
-
-btn.addEventListener('click', function(event) {
-  $('#myModal').modal('show');
-});

app/views/layouts/application.html.erb

@@ -15,5 +15,6 @@
     <%= yield %>
     <%= javascript_include_tag 'application' %>
     <%= javascript_pack_tag 'application' %>
+
   </body>
 </html>

app/views/pages/_contact.html.erb

@@ -61,4 +61,3 @@ end
 </div>
 
 
-<%= javascript_pack_tag 'modal' %>