paoda
/
gb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

chore: replace unimplemented!() with unreachable!()

This commit is contained in:
Rekai Nyangadzayi Musuka 2020-09-07 21:51:20 -05:00
parent cd6f242f56
commit a4b3da1939
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/instruction.rs
View File

@ -199,7 +199,7 @@ impl Instruction {
cpu.set_register(Register::A, cpu.read_byte(nn)); cpu.set_register(Register::A, cpu.read_byte(nn));
Cycles(16) Cycles(16)
} }
_ => unimplemented!(), _ => unreachable!(),
}, },
Instruction::STOP => Cycles(4), Instruction::STOP => Cycles(4),
Instruction::JR(cond, offset) => { Instruction::JR(cond, offset) => {
@ -1334,7 +1334,7 @@ impl Instruction {
(3, 5, 1, _, 0) => Self::CALL(JumpCondition::Always, nn), // CALL nn (3, 5, 1, _, 0) => Self::CALL(JumpCondition::Always, nn), // CALL nn
// (3, 5, 1, _, 1..=3) => unreachable!(), (removed in documentation) // (3, 5, 1, _, 1..=3) => unreachable!(), (removed in documentation)
(3, 6, _, _, _) => Table::x3_alu(y, n), (3, 6, _, _, _) => Table::x3_alu(y, n),
(3, 7, _, _, _) => Self::RST(y * 8), // RST y * 8 (3, 7, _, _, _) => Self::RST(y * 8), // RST n
_ => panic!( _ => panic!(
"Unknown Opcode: {:#x?}\n x: {}, z: {}, q: {}, y: {}, p: {}", "Unknown Opcode: {:#x?}\n x: {}, z: {}, q: {}, y: {}, p: {}",
opcode, x, z, q, y, p opcode, x, z, q, y, p