paoda
/
gb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

chore(ppu): reimplement offset calculation for obj fetcher

This commit is contained in:
Rekai Nyangadzayi Musuka 2021-05-04 22:11:03 -05:00
parent 6f919acafb
commit 2a7377c724
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/ppu.rs
View File

@ -691,10 +691,10 @@ impl PixelFetcher {
TileDataAddress::X8000 => 0x8000 + (id as u16 * 16), TileDataAddress::X8000 => 0x8000 + (id as u16 * 16),
}; };
let offset = if window { let offset = 2 * if window {
2 * (self.bg.window_line.count() % 8) self.bg.window_line.count() % 8
} else { } else {
2 * ((line_y + scroll_y) % 8) (line_y + scroll_y) % 8
}; };
tile_data_addr + offset as u16 tile_data_addr + offset as u16
@ -724,17 +724,15 @@ impl PixelFetcher {
pub fn get_obj_low_addr(attr: &ObjectAttribute, pos: &ScreenPosition, obj_size: u8) -> u16 { pub fn get_obj_low_addr(attr: &ObjectAttribute, pos: &ScreenPosition, obj_size: u8) -> u16 {
let line_y = pos.line_y; let line_y = pos.line_y;
let scroll_y = pos.scroll_y;
// FIXME: Should we subtract 16 from attr.y? let offset = 2 * if attr.flags.y_flip() {
let y = attr.y.wrapping_sub(16); obj_size - (line_y + scroll_y) % 8
let line = if attr.flags.y_flip() {
obj_size - (line_y - y)
} else { } else {
line_y - y (line_y + scroll_y) % 8
}; };
0x8000 + (attr.tile_index as u16 * 16) + (line as u16 * 2) 0x8000 + (attr.tile_index as u16 * 16) + offset as u16
} }
} }