From 985fefb9f657d1003cd4bf969017f5a3d5a45d15 Mon Sep 17 00:00:00 2001
From: Rekai Musuka <rekai@musuka.dev>
Date: Tue, 25 Jan 2022 08:05:42 -0400
Subject: [PATCH] chore(cpu): implement behaviour for undefined test
 instruction

---
 src/cpu/arm/data_processing.zig | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/src/cpu/arm/data_processing.zig b/src/cpu/arm/data_processing.zig
index 078ce47..e1d953c 100644
--- a/src/cpu/arm/data_processing.zig
+++ b/src/cpu/arm/data_processing.zig
@@ -83,16 +83,31 @@ pub fn dataProcessing(comptime I: bool, comptime S: bool, comptime instrKind: u4
                 0x7 => cpu.r[rd] = sbc(S, cpu, rd, op2, op1, old_carry), // RSC
                 0x8 => {
                     // TST
+                    if (rd == 0xF) {
+                        undefinedTestBehaviour(cpu);
+                        return;
+                    }
+
                     const result = op1 & op2;
                     testFlags(S, cpu, opcode, result);
                 },
                 0x9 => {
                     // TEQ
+                    if (rd == 0xF) {
+                        undefinedTestBehaviour(cpu);
+                        return;
+                    }
+
                     const result = op1 ^ op2;
                     testFlags(S, cpu, opcode, result);
                 },
                 0xA => {
                     // CMP
+                    if (rd == 0xF) {
+                        undefinedTestBehaviour(cpu);
+                        return;
+                    }
+
                     const result = op1 -% op2;
 
                     cpu.cpsr.n.write(result >> 31 & 1 == 1);
@@ -102,6 +117,11 @@ pub fn dataProcessing(comptime I: bool, comptime S: bool, comptime instrKind: u4
                 },
                 0xB => {
                     // CMN
+                    if (rd == 0xF) {
+                        undefinedTestBehaviour(cpu);
+                        return;
+                    }
+
                     var result: u32 = undefined;
                     const didOverflow = @addWithOverflow(u32, op1, op2, &result);
 
@@ -192,3 +212,8 @@ fn testFlags(comptime S: bool, cpu: *Arm7tdmi, opcode: u32, result: u32) void {
     // Barrel Shifter should always calc CPSR C in TST
     if (!S) _ = shifter.execute(true, cpu, opcode);
 }
+
+fn undefinedTestBehaviour(cpu: *Arm7tdmi) void {
+    @setCold(true);
+    cpu.setCpsr(cpu.spsr.raw);
+}